refactor(client:main): use controller as, named function, new name #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awk34
force-pushed
the
angular-controller-as
branch
from
9c3e3e3 to
17af68f
Compare
| @@ -6,10 +6,12 @@ angular.module '<%= scriptAppName %>' | |||
| .when '/', | |||
| templateUrl: 'app/main/main.html' | |||
| controller: 'MainCtrl' | |||
Awk34
force-pushed
the
angular-controller-as
branch
2 times, most recently
from
a959473 to
bcf664f
Compare
|
@kingcody I'm having trouble figuring out why that last test case is failing with CoffeeScript. Mind taking a look? |
|
|
||
| MainController = ($scope, $http<% if (filters.socketio) { %>, socket<% } %>) -> | ||
| self = this | ||
| @awesomeThings = [] | ||
| $http.get('/api/things').then (response) -> |
There was a problem hiding this comment.
With no server options this is the last statement in the controller and coffee returns the last statement in a function. Also, when using controller as syntax if the controller returns a value then it is bound to the scope as the controller. So this should be the last statement.
Awk34
force-pushed
the
angular-controller-as
branch
3 times, most recently
from
ff51c05 to
c8038ce
Compare
|
Requires #1287 |
controller as main, MainCtrl -> MainController
kingcody
force-pushed
the
angular-controller-as
branch
from
c8038ce to
7d7daee
Compare
kingcody
added a commit
that referenced
this pull request
Sep 12, 2015
refactor(client:main): use controller as, named function, new name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller as main, MainCtrl -> MainController